summaryrefslogtreecommitdiffstats
path: root/drivers/staging/vc04_services/bcm2835-camera/controls.c
diff options
context:
space:
mode:
authorAishwarya Pant <aishpant@gmail.com>2017-02-28 16:52:50 +0530
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-03-06 09:39:53 +0100
commit4bc58d16753b99e45d84388d7e63b93d7f913a98 (patch)
treeeaabd76e17b38a18ec27e1bf653720a4621b6e4d /drivers/staging/vc04_services/bcm2835-camera/controls.c
parent69385ad9abc34a9051e983f0b62a8f8e472a9037 (diff)
downloadop-kernel-dev-4bc58d16753b99e45d84388d7e63b93d7f913a98.zip
op-kernel-dev-4bc58d16753b99e45d84388d7e63b93d7f913a98.tar.gz
staging: vc04_services: bcm2835-camera: Simplify NULL comparisons
Remove instances of explicit NULL comparisons in bcm2835-camera driver for code compaction. Signed-off-by: Aishwarya Pant <aishpant@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/vc04_services/bcm2835-camera/controls.c')
-rw-r--r--drivers/staging/vc04_services/bcm2835-camera/controls.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c
index 4d7e2a2..9c0667e 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/controls.c
+++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c
@@ -909,9 +909,7 @@ static int bm2835_mmal_s_ctrl(struct v4l2_ctrl *ctrl)
const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl = ctrl->priv;
int ret;
- if ((mmal_ctrl == NULL) ||
- (mmal_ctrl->id != ctrl->id) ||
- (mmal_ctrl->setter == NULL)) {
+ if (!mmal_ctrl || mmal_ctrl->id != ctrl->id || !mmal_ctrl->setter) {
pr_warn("mmal_ctrl:%p ctrl id:%d\n", mmal_ctrl, ctrl->id);
return -EINVAL;
}
OpenPOWER on IntegriCloud