diff options
| author | Lorenzo Stoakes <lstoakes@gmail.com> | 2015-03-10 15:25:47 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-03-10 21:13:55 +0100 |
| commit | f8b0dced35e60a857e893648308e056915ffed4a (patch) | |
| tree | 731d5b697cf2025afe075a64331e59f83b238d0b /drivers/staging/sm750fb/ddk750_help.c | |
| parent | a99e334da16ce81163db0e47ec22469a79a91b72 (diff) | |
| download | op-kernel-dev-f8b0dced35e60a857e893648308e056915ffed4a.zip op-kernel-dev-f8b0dced35e60a857e893648308e056915ffed4a.tar.gz | |
staging: sm750fb: Cleanup the type of mmio750
This patch assigns the more appropriate void* type to the mmio750 variable
eliminating an unnecessary volatile qualifier in the process. Additionally it
updates parameter types as necessary where those parameters interact with
mmio750, removes unnecessary casts and updates the type of the
lynx_share->pvReg field which is passed to the ddk750_set_mmio method.
As a consequence, this patch fixes the following sparse warning:-
drivers/staging/sm750fb/ddk750_help.c:12:17: warning: incorrect type in assignment (different address spaces)
Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/sm750fb/ddk750_help.c')
| -rw-r--r-- | drivers/staging/sm750fb/ddk750_help.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c index cc00d2b..c68ff3b 100644 --- a/drivers/staging/sm750fb/ddk750_help.c +++ b/drivers/staging/sm750fb/ddk750_help.c @@ -2,12 +2,12 @@ //#include "ddk750_chip.h" #include "ddk750_help.h" -volatile unsigned char __iomem * mmio750 = NULL; +void __iomem * mmio750 = NULL; char revId750 = 0; unsigned short devId750 = 0; /* after driver mapped io registers, use this function first */ -void ddk750_set_mmio(volatile unsigned char * addr,unsigned short devId,char revId) +void ddk750_set_mmio(void __iomem * addr,unsigned short devId,char revId) { mmio750 = addr; devId750 = devId; |
