diff options
| author | Dan Carpenter <error27@gmail.com> | 2010-11-12 08:11:13 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-11-16 12:25:53 -0800 |
| commit | 832855354b5863d141ecfc563e78063978c6f29f (patch) | |
| tree | 4bf9d9552daa9ffc98b3368a95a727b125b0c24f /drivers/staging/rtl8712 | |
| parent | f36d83a8cb7224f45fdfa1129a616dff56479a09 (diff) | |
| download | op-kernel-dev-832855354b5863d141ecfc563e78063978c6f29f.zip op-kernel-dev-832855354b5863d141ecfc563e78063978c6f29f.tar.gz | |
Staging: rtl8712: signedness bug in init
PollingCnt is 20 and that means we loop 20 times and then run the
timeout code. After the end of the loop PollingCnt should be -1 but
because it's an unsigned char, it's actually 255 and the timeout
code never runs.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/rtl8712')
| -rw-r--r-- | drivers/staging/rtl8712/usb_halinit.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/rtl8712/usb_halinit.c b/drivers/staging/rtl8712/usb_halinit.c index f6569dc..0e9483b 100644 --- a/drivers/staging/rtl8712/usb_halinit.c +++ b/drivers/staging/rtl8712/usb_halinit.c @@ -37,7 +37,7 @@ u8 r8712_usb_hal_bus_init(struct _adapter *padapter) { u8 val8 = 0; u8 ret = _SUCCESS; - u8 PollingCnt = 20; + int PollingCnt = 20; struct registry_priv *pregistrypriv = &padapter->registrypriv; if (pregistrypriv->chip_version == RTL8712_FPGA) { |
