diff options
| author | Larry Finger <Larry.Finger@lwfinger.net> | 2011-09-01 12:23:18 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-09-06 16:35:58 -0700 |
| commit | ce7b393f50e93da441a4a532ff6ca393fb6bd64a (patch) | |
| tree | 0ce32a90ac94ec6b31690b29bed5fb9639da7d02 /drivers/staging/rtl8192e | |
| parent | a07663eddb2dc84361497352233adfb2ed6f55de (diff) | |
| download | op-kernel-dev-ce7b393f50e93da441a4a532ff6ca393fb6bd64a.zip op-kernel-dev-ce7b393f50e93da441a4a532ff6ca393fb6bd64a.tar.gz | |
staging: rtl8192e: Fix smatch warning in rtl819x_BAProc.c
Smatch outputs the following warning:
CHECK drivers/staging/rtl8192e/rtl819x_BAProc.c
drivers/staging/rtl8192e/rtl819x_BAProc.c +88 rtllib_ADDBA(12) warn: variable dereferenced before check 'ieee'
As ieee cannot be NULL at this point, remove all such checks.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/rtl8192e')
| -rw-r--r-- | drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c index 48f9f71..330a3a9 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -82,12 +82,12 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_device *ieee, u8 *Dst, u8 *tag = NULL; u16 tmp = 0; u16 len = ieee->tx_headroom + 9; + RTLLIB_DEBUG(RTLLIB_DL_TRACE | RTLLIB_DL_BA, "========>%s(), frame(%d)" " sentd to: %pM, ieee->dev:%p\n", __func__, type, Dst, ieee->dev); - if (pBA == NULL || ieee == NULL) { - RTLLIB_DEBUG(RTLLIB_DL_ERR, "pBA(%p) is NULL or ieee(%p) is " - "NULL\n", pBA, ieee); + if (pBA == NULL) { + RTLLIB_DEBUG(RTLLIB_DL_ERR, "pBA(%p) is NULL\n"); return NULL; } skb = dev_alloc_skb(len + sizeof(struct rtllib_hdr_3addr)); |
