diff options
| author | Aaro Koskinen <aaro.koskinen@iki.fi> | 2014-11-07 22:44:58 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-11-26 13:45:11 -0800 |
| commit | 030739f52e0ac1a5c12b04d0ee414f612a9c8729 (patch) | |
| tree | 5bb6227ce718835039d1b207e9b7ad524813b6da /drivers/staging/octeon/octeon-ethernet.h | |
| parent | 698f140d67e0a92b6d4606c67fdf42b3853c34b6 (diff) | |
| download | op-kernel-dev-030739f52e0ac1a5c12b04d0ee414f612a9c8729.zip op-kernel-dev-030739f52e0ac1a5c12b04d0ee414f612a9c8729.tar.gz | |
staging: octeon-ethernet: drop multiple NAPI instances
Octeon Ethernet driver is currently trying to wake up multiple
CPU cores for parallel NAPI processing when needed, to cope
with the fact that all network interfaces are handled through
the same receive queue processed by a single core/interrupt
(see http://marc.info/?l=linux-kernel&m=137209784914565&w=2).
This partially overlaps with generic RPS functionality.
Commit a6a39a7fcff5 ("staging: octeon-ethernet: disable load balance
for receiving packet when CONFIG_RPS is enabled") already disabled this
when RPS is enabled. Let's delete this code altogether as it has issues
like packet reordering and potential problems with CPU offlining/onlining.
Tested on EdgeRouter Lite.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Acked-By: David Daney <david.daney@cavium.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/octeon/octeon-ethernet.h')
| -rw-r--r-- | drivers/staging/octeon/octeon-ethernet.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/staging/octeon/octeon-ethernet.h b/drivers/staging/octeon/octeon-ethernet.h index d0e3211..f48dc76 100644 --- a/drivers/staging/octeon/octeon-ethernet.h +++ b/drivers/staging/octeon/octeon-ethernet.h @@ -99,7 +99,6 @@ extern struct workqueue_struct *cvm_oct_poll_queue; extern atomic_t cvm_oct_poll_queue_stopping; extern u64 cvm_oct_tx_poll_interval; -extern int max_rx_cpus; extern int rx_napi_weight; #endif |
