diff options
| author | Julia Lawall <julia@diku.dk> | 2011-09-16 08:57:33 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-09-16 20:49:18 +0200 |
| commit | c0569981b343a8cb848852a3ebd68bc07b64d873 (patch) | |
| tree | a1810fa80f2dddf1616578ddaab3713e5feaf0dd /drivers/staging/mei | |
| parent | 661d3bf652c0b8eca6f40f2e308b5a719307dd56 (diff) | |
| download | op-kernel-dev-c0569981b343a8cb848852a3ebd68bc07b64d873.zip op-kernel-dev-c0569981b343a8cb848852a3ebd68bc07b64d873.tar.gz | |
drivers/staging/mei/interface.c: take size of pointed value, not pointer
Sizeof a pointer-typed expression returns the size of the pointer, not that
of the pointed data.
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression *e;
type T;
identifier f;
@@
f(...,(T)e,...,
-sizeof(e)
+sizeof(*e)
,...)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/mei')
| -rw-r--r-- | drivers/staging/mei/interface.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/mei/interface.c b/drivers/staging/mei/interface.c index cfec92d..a65dacf 100644 --- a/drivers/staging/mei/interface.c +++ b/drivers/staging/mei/interface.c @@ -332,7 +332,7 @@ int mei_send_flow_control(struct mei_device *dev, struct mei_cl *cl) mei_hdr->reserved = 0; mei_flow_control = (struct hbm_flow_control *) &dev->wr_msg_buf[1]; - memset(mei_flow_control, 0, sizeof(mei_flow_control)); + memset(mei_flow_control, 0, sizeof(*mei_flow_control)); mei_flow_control->host_addr = cl->host_client_id; mei_flow_control->me_addr = cl->me_client_id; mei_flow_control->cmd.cmd = MEI_FLOW_CONTROL_CMD; @@ -396,7 +396,7 @@ int mei_disconnect(struct mei_device *dev, struct mei_cl *cl) mei_cli_disconnect = (struct hbm_client_disconnect_request *) &dev->wr_msg_buf[1]; - memset(mei_cli_disconnect, 0, sizeof(mei_cli_disconnect)); + memset(mei_cli_disconnect, 0, sizeof(*mei_cli_disconnect)); mei_cli_disconnect->host_addr = cl->host_client_id; mei_cli_disconnect->me_addr = cl->me_client_id; mei_cli_disconnect->cmd.cmd = CLIENT_DISCONNECT_REQ_CMD; |
