diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2016-09-12 05:43:49 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@s-opensource.com> | 2016-09-19 14:16:11 -0300 |
| commit | b82e39f85603db6251ffcacf8b0b91674869c6fb (patch) | |
| tree | c6ae1c2f56f7cb7bbad07e9905d1198b234ed997 /drivers/staging/media | |
| parent | 4540e0ad6fa6fab0e4cc0dc4f74b1ebb676a4404 (diff) | |
| download | op-kernel-dev-b82e39f85603db6251ffcacf8b0b91674869c6fb.zip op-kernel-dev-b82e39f85603db6251ffcacf8b0b91674869c6fb.tar.gz | |
[media] pulse8-cec: avoid uninitialized data use
Building with -Wmaybe-uninitialized reveals the use on an uninitialized
variable containing the physical address of the device whenever
firmware before version 2 is used:
drivers/staging/media/pulse8-cec/pulse8-cec.c: In function 'pulse8_connect':
drivers/staging/media/pulse8-cec/pulse8-cec.c:447:2: error: 'pa' may be used uninitialized in this function [-Werror=maybe-uninitialized]
This sets the address to CEC_PHYS_ADDR_INVALID in this case, so we don't
try to write back the uninitialized data to the device.
Fixes: e28a6c8b3fcc ("[media] pulse8-cec: sync configuration with adapter")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/staging/media')
| -rw-r--r-- | drivers/staging/media/pulse8-cec/pulse8-cec.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/staging/media/pulse8-cec/pulse8-cec.c b/drivers/staging/media/pulse8-cec/pulse8-cec.c index 8292cab..9285765 100644 --- a/drivers/staging/media/pulse8-cec/pulse8-cec.c +++ b/drivers/staging/media/pulse8-cec/pulse8-cec.c @@ -342,8 +342,10 @@ static int pulse8_setup(struct pulse8 *pulse8, struct serio *serio, return err; pulse8->vers = (data[0] << 8) | data[1]; dev_info(pulse8->dev, "Firmware version %04x\n", pulse8->vers); - if (pulse8->vers < 2) + if (pulse8->vers < 2) { + *pa = CEC_PHYS_ADDR_INVALID; return 0; + } cmd[0] = MSGCODE_GET_BUILDDATE; err = pulse8_send_and_wait(pulse8, cmd, 1, cmd[0], 4); |
