diff options
| author | Julia Lawall <julia@diku.dk> | 2010-05-15 23:21:43 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-05-17 16:31:15 -0700 |
| commit | 94002c07ff0e207a883519ccc35c0b5390b29331 (patch) | |
| tree | b730a75ef2ad76d1e3a322e5982b30ca46b6c487 /drivers/staging/line6/variax.c | |
| parent | 96fe9ee2c2dfe3268961f3873ea6098b9b9f27c2 (diff) | |
| download | op-kernel-dev-94002c07ff0e207a883519ccc35c0b5390b29331.zip op-kernel-dev-94002c07ff0e207a883519ccc35c0b5390b29331.tar.gz | |
Staging: Use kmemdup
Use kmemdup when some other buffer is immediately copied into the
allocated region.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression from,to,size,flag;
statement S;
@@
- to = \(kmalloc\|kzalloc\)(size,flag);
+ to = kmemdup(from,size,flag);
if (to==NULL || ...) S
- memcpy(to, from, size);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/line6/variax.c')
| -rw-r--r-- | drivers/staging/line6/variax.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c index 28eb899..58ddbe6 100644 --- a/drivers/staging/line6/variax.c +++ b/drivers/staging/line6/variax.c @@ -486,7 +486,8 @@ int variax_init(struct usb_interface *interface, return err; } - variax->buffer_activate = kmalloc(sizeof(variax_activate), GFP_KERNEL); + variax->buffer_activate = kmemdup(variax_activate, + sizeof(variax_activate), GFP_KERNEL); if (variax->buffer_activate == NULL) { dev_err(&interface->dev, "Out of memory\n"); @@ -494,8 +495,6 @@ int variax_init(struct usb_interface *interface, return -ENOMEM; } - memcpy(variax->buffer_activate, variax_activate, - sizeof(variax_activate)); init_timer(&variax->activate_timer); /* create sysfs entries: */ |
