diff options
| author | Tobin C. Harding <me@tobin.cc> | 2017-03-21 13:37:12 +1100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-03-21 08:56:07 +0100 |
| commit | 1770ae9d3f7f2849d7a7a24f93af44a59790a647 (patch) | |
| tree | 1583359f244141428db0e1a88751915ee3641f0f /drivers/staging/ks7010/ks_hostif.c | |
| parent | 1e765f318824b2f182dedb5e74e05b9f132e07ca (diff) | |
| download | op-kernel-dev-1770ae9d3f7f2849d7a7a24f93af44a59790a647.zip op-kernel-dev-1770ae9d3f7f2849d7a7a24f93af44a59790a647.tar.gz | |
staging: ks7010: rename return value identifier
Driver uses multiple identifier names for the same task (retval, ret,
rc). It would be easier to read the code if a single task is
identified with a single name. 'ret' is the most common return value
identifier name found in the kernel tree, following the principle of
least surprise using 'ret' is a decent choice.
Rename rc -> ret
Rename retval -> ret
Signed-off-by: Tobin C. Harding <me@tobin.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/ks7010/ks_hostif.c')
| -rw-r--r-- | drivers/staging/ks7010/ks_hostif.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index 83cda1f..460ab13 100644 --- a/drivers/staging/ks7010/ks_hostif.c +++ b/drivers/staging/ks7010/ks_hostif.c @@ -402,7 +402,7 @@ void hostif_data_indication(struct ks_wlan_private *priv) unsigned short eth_proto; struct ieee802_1x_hdr *aa1x_hdr; struct wpa_eapol_key *eap_key; - int rc; + int ret; DPRINTK(3, "\n"); @@ -434,8 +434,8 @@ void hostif_data_indication(struct ks_wlan_private *priv) /* for WPA */ if (auth_type != TYPE_DATA && priv->wpa.rsn_enabled) { - rc = hostif_data_indication_wpa(priv, auth_type); - if (rc) + ret = hostif_data_indication_wpa(priv, auth_type); + if (ret) return; } @@ -1124,12 +1124,12 @@ int hostif_data_request(struct ks_wlan_private *priv, struct sk_buff *packet) struct ieee802_1x_hdr *aa1x_hdr; struct wpa_eapol_key *eap_key; struct ethhdr *eth; - int rc; + int ret; packet_len = packet->len; if (packet_len > ETH_FRAME_LEN) { DPRINTK(1, "bad length packet_len=%d\n", packet_len); - rc = -EOVERFLOW; + ret = -EOVERFLOW; goto err_kfree_skb; } @@ -1157,7 +1157,7 @@ int hostif_data_request(struct ks_wlan_private *priv, struct sk_buff *packet) if (!pp) { DPRINTK(3, "allocate memory failed..\n"); - rc = -ENOMEM; + ret = -ENOMEM; goto err_kfree_skb; } @@ -1171,7 +1171,7 @@ int hostif_data_request(struct ks_wlan_private *priv, struct sk_buff *packet) if (memcmp(&priv->eth_addr[0], eth->h_source, ETH_ALEN)) { DPRINTK(1, "invalid mac address !!\n"); DPRINTK(1, "ethernet->h_source=%pM\n", eth->h_source); - rc = -ENXIO; + ret = -ENXIO; goto err_kfree; } @@ -1281,7 +1281,7 @@ err_kfree: err_kfree_skb: dev_kfree_skb(packet); - return rc; + return ret; } #define ps_confirm_wait_inc(priv) do { \ |
