diff options
author | Tobin C. Harding <me@tobin.cc> | 2017-04-18 10:35:31 +1000 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-04-18 13:33:17 +0200 |
commit | 055da4f9b95dd2a50c653b5a4559b9186081fb75 (patch) | |
tree | 8f91997ee9dd1d14078db7d756721c97ff60e8af /drivers/staging/ks7010/ks7010_sdio.h | |
parent | 68711cebcbb4dd7f5c05245715eefa4f4d4be760 (diff) | |
download | op-kernel-dev-055da4f9b95dd2a50c653b5a4559b9186081fb75.zip op-kernel-dev-055da4f9b95dd2a50c653b5a4559b9186081fb75.tar.gz |
staging: ks7010: fix complete_handler
complete_handler() takes void * types as parameters. void * parameters are then
cast to struct types. Call sites for this function either pass in NULL
or pointers to the struct types cast to void *. This casting is
unnecessary and can be removed.
Struct tx_device_buffer (which contains a pointer member to the
complete_handler() function) has as member 'ks_wlan_priv *priv' this is
unnecessary, we always have a pointer to this struct there is no need
to store it here.
The complete_handler can be more clearly defined by using struct
pointer types instead of void * types. The code is currently
unnecessarily complex, storing and passing extraneous pointer
parameters.
Remove unnecessary parameters, unnecessary casting to/from 'void
*'. Fix all call sites involving complete_handler().
Signed-off-by: Tobin C. Harding <me@tobin.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/ks7010/ks7010_sdio.h')
-rw-r--r-- | drivers/staging/ks7010/ks7010_sdio.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/staging/ks7010/ks7010_sdio.h b/drivers/staging/ks7010/ks7010_sdio.h index e9b0ad9..5aa593a 100644 --- a/drivers/staging/ks7010/ks7010_sdio.h +++ b/drivers/staging/ks7010/ks7010_sdio.h @@ -108,9 +108,9 @@ struct ks_sdio_card { struct tx_device_buffer { unsigned char *sendp; /* pointer of send req data */ unsigned int size; - void (*complete_handler)(void *arg1, void *arg2); - void *arg1; - void *arg2; + void (*complete_handler)(struct ks_wlan_private *priv, + struct sk_buff *skb); + struct sk_buff *skb; }; struct tx_device { |