summaryrefslogtreecommitdiffstats
path: root/drivers/staging/ks7010/ks7010_sdio.c
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2016-08-13 19:52:38 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-08-15 16:35:13 +0200
commit803394d03b43ba0ef4a9ed148de19c01d87cd13a (patch)
tree99a4c220b5a2fa54b9867e051f93aba23ecbd02d /drivers/staging/ks7010/ks7010_sdio.c
parent6bef3f01398dc12532873f8b2376dba1339908bb (diff)
downloadop-kernel-dev-803394d03b43ba0ef4a9ed148de19c01d87cd13a.zip
op-kernel-dev-803394d03b43ba0ef4a9ed148de19c01d87cd13a.tar.gz
staging: ks7010: do not dereference priv if priv is null
priv is being dereferenced before a check for it being null is made, so there is a possibililty a null pointer deference can occur. Instead, only dereference priv if it is non-null. Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/ks7010/ks7010_sdio.c')
-rw-r--r--drivers/staging/ks7010/ks7010_sdio.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index a0facfc..47b69cb 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -1134,7 +1134,6 @@ static void ks7010_sdio_remove(struct sdio_func *func)
int ret;
struct ks_sdio_card *card;
struct ks_wlan_private *priv;
- struct net_device *netdev;
DPRINTK(1, "ks7010_sdio_remove()\n");
card = sdio_get_drvdata(func);
@@ -1144,8 +1143,9 @@ static void ks7010_sdio_remove(struct sdio_func *func)
DPRINTK(1, "priv = card->priv\n");
priv = card->priv;
- netdev = priv->net_dev;
if (priv) {
+ struct net_device *netdev = priv->net_dev;
+
ks_wlan_net_stop(netdev);
DPRINTK(1, "ks_wlan_net_stop\n");
OpenPOWER on IntegriCloud