summaryrefslogtreecommitdiffstats
path: root/drivers/staging/greybus/svc.c
diff options
context:
space:
mode:
authorJohan Hovold <johan@hovoldconsulting.com>2016-07-19 17:21:27 +0200
committerGreg Kroah-Hartman <gregkh@google.com>2016-07-19 18:27:35 -0700
commit042fd749abab492ae02452cf675f7bc146814955 (patch)
treec6af2bd1807bfd888816e8ebde4d9e3745acf0e7 /drivers/staging/greybus/svc.c
parentd53cc1c37e5a4006fb23df8e54dc4a50e01732d9 (diff)
downloadop-kernel-dev-042fd749abab492ae02452cf675f7bc146814955.zip
op-kernel-dev-042fd749abab492ae02452cf675f7bc146814955.tar.gz
greybus: connection: drop the svc quiescing operation
Connection tear down is being reworked, and the SVC quiescing operation is going away. Let's remove this operation now along with the coupled second ping from our intermediate tear down implementation. This both avoids unnecessary noise in the logs resulting from the fact that the SVC side of the quiescing operation was never merged, and speeds up connection tear down slightly. Testing done: Tested on EVT2 using runtime PM. Signed-off-by: Johan Hovold <johan@hovoldconsulting.com> Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org> Acked-by: Sandeep Patil <sspatil@google.com> Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Diffstat (limited to 'drivers/staging/greybus/svc.c')
-rw-r--r--drivers/staging/greybus/svc.c31
1 files changed, 0 insertions, 31 deletions
diff --git a/drivers/staging/greybus/svc.c b/drivers/staging/greybus/svc.c
index 14bada9..da9bb1f 100644
--- a/drivers/staging/greybus/svc.c
+++ b/drivers/staging/greybus/svc.c
@@ -470,37 +470,6 @@ int gb_svc_connection_create(struct gb_svc *svc,
}
EXPORT_SYMBOL_GPL(gb_svc_connection_create);
-void gb_svc_connection_quiescing(struct gb_svc *svc, u8 intf1_id, u16 cport1_id,
- u8 intf2_id, u16 cport2_id)
-{
- struct gb_svc_conn_quiescing_request request;
- struct gb_svc_conn_quiescing_response response;
- int ret;
-
- dev_dbg(&svc->dev, "%s - (%u:%u %u:%u)\n", __func__,
- intf1_id, cport1_id, intf2_id, cport2_id);
-
- request.intf1_id = intf1_id;
- request.cport1_id = cpu_to_le16(cport1_id);
- request.intf2_id = intf2_id;
- request.cport2_id = cpu_to_le16(cport2_id);
-
- ret = gb_operation_sync(svc->connection, GB_SVC_TYPE_CONN_QUIESCING,
- &request, sizeof(request),
- &response, sizeof(response));
- if (ret < 0)
- return;
- if (response.status != GB_SVC_OP_SUCCESS) {
- dev_err(&svc->dev, "quiescing connection failed (%u:%u %u:%u): %u\n",
- intf1_id, cport1_id, intf2_id, cport2_id,
- response.status);
- return;
- }
-
- return;
-}
-EXPORT_SYMBOL_GPL(gb_svc_connection_quiescing);
-
void gb_svc_connection_destroy(struct gb_svc *svc, u8 intf1_id, u16 cport1_id,
u8 intf2_id, u16 cport2_id)
{
OpenPOWER on IntegriCloud