diff options
author | Rui Miguel Silva <rmfrfs@gmail.com> | 2016-09-30 19:24:31 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-10-02 15:49:25 +0200 |
commit | 85a42dc8676c2ea15fb44715eef85a7a419254a0 (patch) | |
tree | ff3dd3efa8be0507e2e81cf1351730e66e387ad0 /drivers/staging/greybus/sdio.c | |
parent | 71bad7f086419dc674244b91ca35a12bfa4cb597 (diff) | |
download | op-kernel-dev-85a42dc8676c2ea15fb44715eef85a7a419254a0.zip op-kernel-dev-85a42dc8676c2ea15fb44715eef85a7a419254a0.tar.gz |
staging: greybus: sdio: fix cmd_flags check for none response
When checking for command flags field if response is not available we
really need to compare it with the right define and not bitwise AND it.
smatch warn:
drivers/staging/greybus/sdio.c:481 gb_sdio_command()
warn: bitwise AND condition is false here
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/greybus/sdio.c')
-rw-r--r-- | drivers/staging/greybus/sdio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c index c7133b1..5649ef1 100644 --- a/drivers/staging/greybus/sdio.c +++ b/drivers/staging/greybus/sdio.c @@ -478,7 +478,7 @@ static int gb_sdio_command(struct gb_sdio_host *host, struct mmc_command *cmd) goto out; /* no response expected */ - if (cmd_flags & GB_SDIO_RSP_NONE) + if (cmd_flags == GB_SDIO_RSP_NONE) goto out; /* long response expected */ |