diff options
| author | David Lin <dtwlin@google.com> | 2016-07-22 13:46:25 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@google.com> | 2016-07-22 13:57:11 -0700 |
| commit | e514dec730284da080286bdf7229d21c2be68b24 (patch) | |
| tree | 6c5c3d84e517386e328f3b140b3523fbbb8794dc /drivers/staging/greybus/operation.c | |
| parent | 098dfaf45e76442d032207d2023930c685ab7c2e (diff) | |
| download | op-kernel-dev-e514dec730284da080286bdf7229d21c2be68b24.zip op-kernel-dev-e514dec730284da080286bdf7229d21c2be68b24.tar.gz | |
greybus: operation: print id when synchronous operation timeout
In case of a synchronous operation timeout error, it's helpful for
purpose of debugging to print the operation id in the error message, so
that we know if the response is received at a later time after operation
time out.
Testing Done:
- Observe the error message below when response comes later after
operation timeout:
[ 792.973978] greybus greybus1: 0/0:0: synchronous operation id 0x0005
of type 0x21 failed: -110
[ 800.646694] greybus greybus1: 0/0:0: unexpected response id 0x0005
received
Signed-off-by: David Lin <dtwlin@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Diffstat (limited to 'drivers/staging/greybus/operation.c')
| -rw-r--r-- | drivers/staging/greybus/operation.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/greybus/operation.c b/drivers/staging/greybus/operation.c index 659e84b..7475ec7 100644 --- a/drivers/staging/greybus/operation.c +++ b/drivers/staging/greybus/operation.c @@ -1128,8 +1128,8 @@ int gb_operation_sync_timeout(struct gb_connection *connection, int type, ret = gb_operation_request_send_sync_timeout(operation, timeout); if (ret) { dev_err(&connection->hd->dev, - "%s: synchronous operation of type 0x%02x failed: %d\n", - connection->name, type, ret); + "%s: synchronous operation id 0x%04x of type 0x%02x failed: %d\n", + connection->name, operation->id, type, ret); } else { if (response_size) { memcpy(response, operation->response->payload, |
