summaryrefslogtreecommitdiffstats
path: root/drivers/staging/greybus/interface.c
diff options
context:
space:
mode:
authorJohan Hovold <johan@hovoldconsulting.com>2016-04-28 16:19:39 +0200
committerGreg Kroah-Hartman <gregkh@google.com>2016-04-28 08:13:46 -0700
commit6ddbed576606a454353638dbbbcc2f66f0fc712d (patch)
treeb5a3e9d2e9e9628c76c5ab3fa1b9fe5d63eef671 /drivers/staging/greybus/interface.c
parent9e04fb7b1627ad55b63c4e0927f696ecb1a2563a (diff)
downloadop-kernel-dev-6ddbed576606a454353638dbbbcc2f66f0fc712d.zip
op-kernel-dev-6ddbed576606a454353638dbbbcc2f66f0fc712d.tar.gz
greybus: interface: fix broken UniPro flow control
A recent commit inadvertently disabled E2EFC on all interface connections, due to a failure to clear the ES3 bootrom quirk flags during mode switch. Testing Done: Verified that the CPort flags are again set to 0x7 for non-bootrom interface connections. Fixes: 5b638080e94e ("svc: keep interfaces registered during mode switch") Signed-off-by: Johan Hovold <johan@hovoldconsulting.com> Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Diffstat (limited to 'drivers/staging/greybus/interface.c')
-rw-r--r--drivers/staging/greybus/interface.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/staging/greybus/interface.c b/drivers/staging/greybus/interface.c
index f6c058a..b5ad1ac 100644
--- a/drivers/staging/greybus/interface.c
+++ b/drivers/staging/greybus/interface.c
@@ -226,6 +226,9 @@ static int gb_interface_read_and_clear_init_status(struct gb_interface *intf)
intf->quirks |= GB_INTERFACE_QUIRK_NO_CPORT_FEATURES;
intf->quirks |= GB_INTERFACE_QUIRK_NO_INTERFACE_VERSION;
break;
+ default:
+ intf->quirks &= ~GB_INTERFACE_QUIRK_NO_CPORT_FEATURES;
+ intf->quirks &= ~GB_INTERFACE_QUIRK_NO_INTERFACE_VERSION;
}
/* Clear the init status. */
OpenPOWER on IntegriCloud