summaryrefslogtreecommitdiffstats
path: root/drivers/staging/greybus/interface.c
diff options
context:
space:
mode:
authorJohan Hovold <johan@hovoldconsulting.com>2016-03-09 12:20:33 +0100
committerGreg Kroah-Hartman <gregkh@google.com>2016-03-10 13:57:42 -0800
commit60269b958ea127a46be9caf0deff931384c4dd2f (patch)
treef3fb2b76b1496f1fe5bccf4d25219c46367db85b /drivers/staging/greybus/interface.c
parent52bbd5b3a04816cdd65605c53dd033d3d987cfee (diff)
downloadop-kernel-dev-60269b958ea127a46be9caf0deff931384c4dd2f.zip
op-kernel-dev-60269b958ea127a46be9caf0deff931384c4dd2f.tar.gz
greybus: interface: add comment about early control-connection disable
Add comment about why the control connection is disabled early when the interface is already gone. Signed-off-by: Johan Hovold <johan@hovoldconsulting.com> Reviewed-by: Jeffrey Carlyle <jcarlyle@google.com> Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Diffstat (limited to 'drivers/staging/greybus/interface.c')
-rw-r--r--drivers/staging/greybus/interface.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/staging/greybus/interface.c b/drivers/staging/greybus/interface.c
index 2f3966f..5c5c422 100644
--- a/drivers/staging/greybus/interface.c
+++ b/drivers/staging/greybus/interface.c
@@ -147,6 +147,10 @@ void gb_interface_remove(struct gb_interface *intf)
struct gb_bundle *bundle;
struct gb_bundle *next;
+ /*
+ * Disable the control-connection early to avoid operation timeouts
+ * when the interface is already gone.
+ */
if (intf->disconnected)
gb_control_disable(intf->control);
OpenPOWER on IntegriCloud