diff options
| author | Johan Hovold <johan@hovoldconsulting.com> | 2015-03-19 16:46:17 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <greg@kroah.com> | 2015-03-19 17:28:19 +0100 |
| commit | 25eb732954ee656edd92770f498d28f87086511b (patch) | |
| tree | f7a705648d1145192123a61d049440c055dbfa89 /drivers/staging/greybus/i2c.c | |
| parent | fe4c0e548aea5f4bc2df967db69d7d0b509327ef (diff) | |
| download | op-kernel-dev-25eb732954ee656edd92770f498d28f87086511b.zip op-kernel-dev-25eb732954ee656edd92770f498d28f87086511b.tar.gz | |
greybus: connection: replace custom error function with dev_err
Remove custom connection error function and replace it with dev_err.
The standard error function provides more information in the message
prefix (e.g. includes the interface id), has a well-known semantics
(e.g. does does not add newlines to messages), and is even somewhat
shorter to type.
Note that some uses of the custom function were already adding double
newlines due to the non-standard semantics.
Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
Diffstat (limited to 'drivers/staging/greybus/i2c.c')
| -rw-r--r-- | drivers/staging/greybus/i2c.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/greybus/i2c.c b/drivers/staging/greybus/i2c.c index 0bcd7a9..84d20e5 100644 --- a/drivers/staging/greybus/i2c.c +++ b/drivers/staging/greybus/i2c.c @@ -178,8 +178,8 @@ gb_i2c_operation_create(struct gb_connection *connection, u32 i; if (msg_count > (u32)U16_MAX) { - gb_connection_err(connection, "msg_count (%u) too big", - msg_count); + dev_err(&connection->dev, "msg_count (%u) too big\n", + msg_count); return NULL; } op_count = (u16)msg_count; |
