diff options
| author | Johan Hovold <johan@hovoldconsulting.com> | 2015-11-22 10:12:58 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@google.com> | 2015-11-23 19:23:27 -0800 |
| commit | bfe2c99c1cd346b06a7d34274b9b826d40ab40a1 (patch) | |
| tree | de9fbddeb794a023ff5057c2de263806f1067b4b /drivers/staging/greybus/hd.c | |
| parent | 39f36c8f9ff6203301a1d7feb7f51d2563abbd3a (diff) | |
| download | op-kernel-dev-bfe2c99c1cd346b06a7d34274b9b826d40ab40a1.zip op-kernel-dev-bfe2c99c1cd346b06a7d34274b9b826d40ab40a1.tar.gz | |
greybus: hd: fix cport-count check
Fix off-by-one error when checking the number of cports a host-device
supports.
The CPORT_ID_MAX is the largest valid cport id so the maximum number of
cports a host-device can use is CPORT_ID_MAX + 1.
Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Diffstat (limited to 'drivers/staging/greybus/hd.c')
| -rw-r--r-- | drivers/staging/greybus/hd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/greybus/hd.c b/drivers/staging/greybus/hd.c index b22d547..3446fec 100644 --- a/drivers/staging/greybus/hd.c +++ b/drivers/staging/greybus/hd.c @@ -49,7 +49,7 @@ struct gb_host_device *gb_hd_create(struct gb_hd_driver *driver, return ERR_PTR(-EINVAL); } - if (num_cports == 0 || num_cports > CPORT_ID_MAX) { + if (num_cports == 0 || num_cports > CPORT_ID_MAX + 1) { dev_err(parent, "Invalid number of CPorts: %zu\n", num_cports); return ERR_PTR(-EINVAL); } |
