diff options
| author | Johan Hovold <johan@hovoldconsulting.com> | 2015-03-19 16:51:10 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <greg@kroah.com> | 2015-03-19 17:29:40 +0100 |
| commit | 56c2da1873d68b96458064a306e5bb4c50ccdb5d (patch) | |
| tree | 87d3f7e0447a16b2e89376cb03b7307c1174003c /drivers/staging/greybus/gpio.c | |
| parent | c2a66106867343b5c5f017ccc724ba1c1aa9b540 (diff) | |
| download | op-kernel-dev-56c2da1873d68b96458064a306e5bb4c50ccdb5d.zip op-kernel-dev-56c2da1873d68b96458064a306e5bb4c50ccdb5d.tar.gz | |
greybus: gpio: remove incorrect todo comments
The module reference count is incremented by gpiolib when a gpio is
requested, and the driver callbacks certainly do sleep.
Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
Diffstat (limited to 'drivers/staging/greybus/gpio.c')
| -rw-r--r-- | drivers/staging/greybus/gpio.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c index f75dd40..6a493d4 100644 --- a/drivers/staging/greybus/gpio.c +++ b/drivers/staging/greybus/gpio.c @@ -747,7 +747,7 @@ static int gb_gpio_connection_init(struct gb_connection *connection) gpio->label = "greybus_gpio"; gpio->dev = &connection->dev; - gpio->owner = THIS_MODULE; /* XXX Module get? */ + gpio->owner = THIS_MODULE; gpio->request = gb_gpio_request; gpio->free = gb_gpio_free; @@ -761,7 +761,7 @@ static int gb_gpio_connection_init(struct gb_connection *connection) gpio->to_irq = gb_gpio_to_irq; gpio->base = -1; /* Allocate base dynamically */ gpio->ngpio = gb_gpio_controller->line_max + 1; - gpio->can_sleep = true; /* XXX */ + gpio->can_sleep = true; ret = gpiochip_add(gpio); if (ret) { |
