summaryrefslogtreecommitdiffstats
path: root/drivers/staging/greybus/camera.c
diff options
context:
space:
mode:
authorJacopo Mondi <jacopo.mondi@linaro.org>2016-06-30 09:18:00 -0500
committerAlex Elder <elder@linaro.org>2016-07-05 21:18:03 -0500
commit36ab1108b60eb649c7c0f0653f854afc1234cfcb (patch)
treea552ada3635718e77b9c0268e7d12184129b00d2 /drivers/staging/greybus/camera.c
parent7f93eab7c705527b0579b1bfd4d6e9f6acc9e5ca (diff)
downloadop-kernel-dev-36ab1108b60eb649c7c0f0653f854afc1234cfcb.zip
op-kernel-dev-36ab1108b60eb649c7c0f0653f854afc1234cfcb.tar.gz
greybus: camera: Fix number of configured streams
Camera Module may report a lower number of configured streams than the one requested by the AP. All the non-supported stream configuration are zeroed. Make the stream configuration inspection loop take only the valid stream into account, to avoid unnecessarily accessing zeroed memory areas. So far, inspecting non valid streams configuration has prove to be harmless, but as we'll need to inspect stream characteristics as reported image sizes and format, we have to take only valid configurations into account. Testing Done: White Camera Module preview and capture. Signed-off-by: Jacopo Mondi <jacopo.mondi@linaro.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@linaro.org> Signed-off-by: Alex Elder <elder@linaro.org>
Diffstat (limited to 'drivers/staging/greybus/camera.c')
-rw-r--r--drivers/staging/greybus/camera.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
index 584f85e..41891b2 100644
--- a/drivers/staging/greybus/camera.c
+++ b/drivers/staging/greybus/camera.c
@@ -435,7 +435,7 @@ static int gb_camera_configure_streams(struct gb_camera *gcam,
*flags = resp->flags;
*num_streams = resp->num_streams;
- for (i = 0; i < nstreams; ++i) {
+ for (i = 0; i < resp->num_streams; ++i) {
struct gb_camera_stream_config_response *cfg = &resp->config[i];
streams[i].width = le16_to_cpu(cfg->width);
OpenPOWER on IntegriCloud