summaryrefslogtreecommitdiffstats
path: root/drivers/staging/dgap
diff options
context:
space:
mode:
authorSomya Anand <somyaanand214@gmail.com>2015-03-11 17:02:14 +0530
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-03-16 16:17:31 +0100
commit2049f1ea88fa07e5912c67c4c623bb342b4b02af (patch)
treec218186f3c79301f6ace9b49a1d1657bbee80e4b /drivers/staging/dgap
parentdc6ed26dc32f2365647e9a156beafe3dcbde612e (diff)
downloadop-kernel-dev-2049f1ea88fa07e5912c67c4c623bb342b4b02af.zip
op-kernel-dev-2049f1ea88fa07e5912c67c4c623bb342b4b02af.tar.gz
Staging: dgap: Use setup_timer to combine initialization
The function setup_timer combines the initialization of a timer with the initialization of the timer's function and data fields. So, this patch combines the multiline code for timer initialization using the function setup_timer. This issue is identified via coccinelle script. @@ expression E1, E2, E3; type T; @@ - init_timer(&E1); ... ( - E1.function = E2; ... - E1.data = (T)E3; + setup_timer(&E1, E2, (T)E3); | - E1.data = (T)E3; ... - E1.function = E2; + setup_timer(&E1, E2, (T)E3); | - E1.function = E2; + setup_timer(&E1, E2, 0); ) Signed-off-by: Somya Anand <somyaanand214@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/dgap')
-rw-r--r--drivers/staging/dgap/dgap.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index cea5b26..6766d5a 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@ -7039,8 +7039,7 @@ static int dgap_start(void)
/* Start the poller */
spin_lock_irqsave(&dgap_poll_lock, flags);
- init_timer(&dgap_poll_timer);
- dgap_poll_timer.function = dgap_poll_handler;
+ setup_timer(&dgap_poll_timer, dgap_poll_handler, 0);
dgap_poll_timer.data = 0;
dgap_poll_time = jiffies + dgap_jiffies_from_ms(dgap_poll_tick);
dgap_poll_timer.expires = dgap_poll_time;
OpenPOWER on IntegriCloud