diff options
author | Andrew Lunn <andrew@lunn.ch> | 2010-03-22 22:46:13 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-05-11 11:35:59 -0700 |
commit | 107c32fe68f0b64acb7edd31d44d79b87c7fa8b4 (patch) | |
tree | 35e140dc6bab13adf9085e08513596b4f29e5d84 /drivers/staging/batman-adv/vis.h | |
parent | 11d91a4456bbc63d2b79ea5f16ffc31ae53cdf79 (diff) | |
download | op-kernel-dev-107c32fe68f0b64acb7edd31d44d79b87c7fa8b4.zip op-kernel-dev-107c32fe68f0b64acb7edd31d44d79b87c7fa8b4.tar.gz |
Staging: batman-adv: don't have interrupts disabled while sending.
send_vis_packets() would disable interrupts before calling
dev_queue_xmit() which resulting in a backtrace in local_bh_enable().
Fix this by using kref on the vis_info object so that we can call
send_vis_packets() without holding vis_hash_lock. vis_hash_lock also
used to protect recv_list, so we now need a new lock to protect that
instead of vis_hash_lock.
Also a few checkpatch cleanups.
Reported-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/batman-adv/vis.h')
-rw-r--r-- | drivers/staging/batman-adv/vis.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/staging/batman-adv/vis.h b/drivers/staging/batman-adv/vis.h index 0cdafde..465da47 100644 --- a/drivers/staging/batman-adv/vis.h +++ b/drivers/staging/batman-adv/vis.h @@ -29,6 +29,7 @@ struct vis_info { /* list of server-neighbors we received a vis-packet * from. we should not reply to them. */ struct list_head send_list; + struct kref refcount; /* this packet might be part of the vis send queue. */ struct vis_packet packet; /* vis_info may follow here*/ |