summaryrefslogtreecommitdiffstats
path: root/drivers/spi
diff options
context:
space:
mode:
authorJohn Ogness <john.ogness@linutronix.de>2009-11-24 16:53:07 +0000
committerGrant Likely <grant.likely@secretlab.ca>2009-12-08 18:48:16 -0700
commitbbd050af0e2b7d77bfc959cf76219eb71c3b982a (patch)
tree9a4da1f3a330ecdc5c6bbba7494940d74376ce79 /drivers/spi
parentce1807b2e527979bd77d8a1a1768a6365f3febb5 (diff)
downloadop-kernel-dev-bbd050af0e2b7d77bfc959cf76219eb71c3b982a.zip
op-kernel-dev-bbd050af0e2b7d77bfc959cf76219eb71c3b982a.tar.gz
spi/i.MX: fix broken error handling for gpio_request
i.MX35-provided chipselects are represented using negative numbers. If gpio_request() fails and the previous chipselect was a negative number, the while loop is endless (i is never decremented). Also, the error loop would never call gpio_free on chipselect[0]. And finally, the error message was missing an endline. Signed-off-by: John Ogness <john.ogness@linutronix.de> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Diffstat (limited to 'drivers/spi')
-rw-r--r--drivers/spi/spi_imx.c9
1 files changed, 5 insertions, 4 deletions
diff --git a/drivers/spi/spi_imx.c b/drivers/spi/spi_imx.c
index 1b17f44..8ffa48c 100644
--- a/drivers/spi/spi_imx.c
+++ b/drivers/spi/spi_imx.c
@@ -516,11 +516,12 @@ static int __init spi_imx_probe(struct platform_device *pdev)
continue;
ret = gpio_request(spi_imx->chipselect[i], DRIVER_NAME);
if (ret) {
- i--;
- while (i > 0)
+ while (i > 0) {
+ i--;
if (spi_imx->chipselect[i] >= 0)
- gpio_free(spi_imx->chipselect[i--]);
- dev_err(&pdev->dev, "can't get cs gpios");
+ gpio_free(spi_imx->chipselect[i]);
+ }
+ dev_err(&pdev->dev, "can't get cs gpios\n");
goto out_master_put;
}
}
OpenPOWER on IntegriCloud