diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2013-11-15 15:50:59 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@linaro.org> | 2013-11-15 10:32:38 +0000 |
| commit | ec3252687ae4ad0c3889010aee726c7a05606fe0 (patch) | |
| tree | 3928de26b99cff33f3f484cfc89b822fc5cb1408 /drivers/spi | |
| parent | 82f85cf98f0eb60093e8b3d606711c2d49538478 (diff) | |
| download | op-kernel-dev-ec3252687ae4ad0c3889010aee726c7a05606fe0.zip op-kernel-dev-ec3252687ae4ad0c3889010aee726c7a05606fe0.tar.gz | |
spi: bcm63xx: fix reference leak to master in bcm63xx_spi_remove()
Once a spi_master_get() call succeeds, we need an additional
spi_master_put() call to free the memory, otherwise we will
leak a reference to master. Fix by removing the unnecessary
spi_master_get() call.
Fixes: 247263dba208 ('spi: bcm63xx: use devm_spi_register_master()')
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Mark Brown <broonie@linaro.org>
Diffstat (limited to 'drivers/spi')
| -rw-r--r-- | drivers/spi/spi-bcm63xx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c index 80d56b2..469ecd8 100644 --- a/drivers/spi/spi-bcm63xx.c +++ b/drivers/spi/spi-bcm63xx.c @@ -435,7 +435,7 @@ out: static int bcm63xx_spi_remove(struct platform_device *pdev) { - struct spi_master *master = spi_master_get(platform_get_drvdata(pdev)); + struct spi_master *master = platform_get_drvdata(pdev); struct bcm63xx_spi *bs = spi_master_get_devdata(master); /* reset spi block */ |
