summaryrefslogtreecommitdiffstats
path: root/drivers/spi
diff options
context:
space:
mode:
authorRichard Genoud <richard.genoud@gmail.com>2011-01-07 15:26:01 +0100
committerGrant Likely <grant.likely@secretlab.ca>2011-01-07 10:01:23 -0700
commit735759389b7143f95ae7badc97511e7e4729e873 (patch)
tree48481675a7d52ce1a1af6bbf6c47fa6095b5a54d /drivers/spi
parent77e58efd134b553d723fd963f436920a6aaaa6df (diff)
downloadop-kernel-dev-735759389b7143f95ae7badc97511e7e4729e873.zip
op-kernel-dev-735759389b7143f95ae7badc97511e7e4729e873.tar.gz
spi/imx: correct the test on platform_get_irq() return value
The test "if (spi_imx->irq <= 0)" is not testing the IRQ value, but the return value of platform_get_irq(). As platform_get_irq() can return an error (-ENXIO) or the IRQ value it found, the test should be "if (spi_imx->irq < 0)" [grant.likely: Note: In general, Linux irq number 0 should also mean no irq, but arm still allows devices to be assigned 0, and the imx platform uses 0 for one of the spi devices, so this patch is needed for the device to work] Signed-off-by: Richard Genoud <richard.genoud@gmail.com> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Diffstat (limited to 'drivers/spi')
-rw-r--r--drivers/spi/spi_imx.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spi_imx.c b/drivers/spi/spi_imx.c
index 9010ef0..9469564 100644
--- a/drivers/spi/spi_imx.c
+++ b/drivers/spi/spi_imx.c
@@ -821,7 +821,7 @@ static int __devinit spi_imx_probe(struct platform_device *pdev)
}
spi_imx->irq = platform_get_irq(pdev, 0);
- if (spi_imx->irq <= 0) {
+ if (spi_imx->irq < 0) {
ret = -EINVAL;
goto out_iounmap;
}
OpenPOWER on IntegriCloud