diff options
| author | Marek Vasut <marex@denx.de> | 2017-04-18 20:09:06 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2017-04-18 19:16:49 +0100 |
| commit | 400c18e3dc86e04ef5afec9b86a8586ca629b9e9 (patch) | |
| tree | f598d12dc23205ecdeeaccc284cfe85a474d177a /drivers/spi/spi-dw-mmio.c | |
| parent | fafd67940774733fa97f4b09412aea6981b82e0a (diff) | |
| download | op-kernel-dev-400c18e3dc86e04ef5afec9b86a8586ca629b9e9.zip op-kernel-dev-400c18e3dc86e04ef5afec9b86a8586ca629b9e9.tar.gz | |
spi: dw: Disable clock after unregistering the host
The dw_mmio driver disables the block clock before unregistering
the host. The code unregistering the host may access the SPI block
registers. If register access happens with block clock disabled,
this may lead to a bus hang. Disable the clock after unregistering
the host to prevent such situation.
This bug was observed on Altera Cyclone V SoC.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mark Brown <broonie@kernel.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-dw-mmio.c')
| -rw-r--r-- | drivers/spi/spi-dw-mmio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c index 447497e..d25cc40 100644 --- a/drivers/spi/spi-dw-mmio.c +++ b/drivers/spi/spi-dw-mmio.c @@ -115,8 +115,8 @@ static int dw_spi_mmio_remove(struct platform_device *pdev) { struct dw_spi_mmio *dwsmmio = platform_get_drvdata(pdev); - clk_disable_unprepare(dwsmmio->clk); dw_spi_remove_host(&dwsmmio->dws); + clk_disable_unprepare(dwsmmio->clk); return 0; } |
