summaryrefslogtreecommitdiffstats
path: root/drivers/spi/spi-bcm63xx.c
diff options
context:
space:
mode:
authorGuenter Roeck <linux@roeck-us.net>2012-08-10 13:56:27 -0700
committerMark Brown <broonie@opensource.wolfsonmicro.com>2012-08-13 13:29:20 +0100
commit1f68237865b2f55badbb3f73792d573899a62475 (patch)
treea411b3fe35a39e8a4f6d3cb25939eead5e85501a /drivers/spi/spi-bcm63xx.c
parent37a2d84a38df16e614bbfbb18a5155ebd8256938 (diff)
downloadop-kernel-dev-1f68237865b2f55badbb3f73792d573899a62475.zip
op-kernel-dev-1f68237865b2f55badbb3f73792d573899a62475.tar.gz
spi/bcm63xx: Ensure that memory is freed only after it is no longer used
The call to spi_unregister_master() in the device remove function frees device memory, and with it any device local data. However, device local data is still accessed after the call to spi_unregister_master(). Acquire a reference to the SPI device and release it after cleanup is complete to solve the problem. Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'drivers/spi/spi-bcm63xx.c')
-rw-r--r--drivers/spi/spi-bcm63xx.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
index 6e25ef1..ea0aaa3 100644
--- a/drivers/spi/spi-bcm63xx.c
+++ b/drivers/spi/spi-bcm63xx.c
@@ -438,7 +438,7 @@ out:
static int __devexit bcm63xx_spi_remove(struct platform_device *pdev)
{
- struct spi_master *master = platform_get_drvdata(pdev);
+ struct spi_master *master = spi_master_get(platform_get_drvdata(pdev));
struct bcm63xx_spi *bs = spi_master_get_devdata(master);
spi_unregister_master(master);
@@ -452,6 +452,8 @@ static int __devexit bcm63xx_spi_remove(struct platform_device *pdev)
platform_set_drvdata(pdev, 0);
+ spi_master_put(master);
+
return 0;
}
OpenPOWER on IntegriCloud