summaryrefslogtreecommitdiffstats
path: root/drivers/soc
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2015-10-12 22:43:15 +0200
committerAndy Gross <agross@codeaurora.org>2015-10-14 14:51:22 -0500
commit6083096d961f3cf754c4da282179053f7b85ac16 (patch)
tree154cb5ff00930b58a5cd0f3fdbad45c3e802be93 /drivers/soc
parent33e38b4f1c54f9c2d3b2034c18ef937a3c09bc66 (diff)
downloadop-kernel-dev-6083096d961f3cf754c4da282179053f7b85ac16.zip
op-kernel-dev-6083096d961f3cf754c4da282179053f7b85ac16.tar.gz
soc: qcom: smd: delete unneeded of_node_put
Device node iterators perform an of_node_put on each iteration, so putting an of_node_put before a continue results in a double put. A simplified version of the semantic match that finds this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ expression root,e; local idexpression child; iterator i; @@ i(..., child, ...) { ... when != of_node_get(child) * of_node_put(child); ... * continue; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Andy Gross <agross@codeaurora.org>
Diffstat (limited to 'drivers/soc')
-rw-r--r--drivers/soc/qcom/smd.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/soc/qcom/smd.c b/drivers/soc/qcom/smd.c
index ef5fed6..86b598c 100644
--- a/drivers/soc/qcom/smd.c
+++ b/drivers/soc/qcom/smd.c
@@ -921,10 +921,8 @@ static struct device_node *qcom_smd_match_channel(struct device_node *edge_node,
for_each_available_child_of_node(edge_node, child) {
key = "qcom,smd-channels";
ret = of_property_read_string(child, key, &name);
- if (ret) {
- of_node_put(child);
+ if (ret)
continue;
- }
if (strcmp(name, channel) == 0)
return child;
OpenPOWER on IntegriCloud