summaryrefslogtreecommitdiffstats
path: root/drivers/scsi
diff options
context:
space:
mode:
authorMilton Miller <miltonm@bga.com>2008-07-10 16:29:37 -0500
committerJesse Barnes <jbarnes@virtuousgeek.org>2008-10-20 10:48:34 -0700
commitedbc25caaa492a82e19baa915f1f6b0a0db6554d (patch)
tree967dbd4f8d35fd8532a612fef55691586b831965 /drivers/scsi
parent7d67474e506598fe26e0c262acf02132dc730517 (diff)
downloadop-kernel-dev-edbc25caaa492a82e19baa915f1f6b0a0db6554d.zip
op-kernel-dev-edbc25caaa492a82e19baa915f1f6b0a0db6554d.tar.gz
PCI: remove dynids.use_driver_data
The driver flag dynids.use_driver_data is almost consistently not set, and causes more problems than it solves. It was initially intended as a flag to indicate whether a driver's usage of driver_data had been carefully inspected and was ready for values from userspace. That audit was never done, so most drivers just get a 0 for driver_data when new IDs are added from userspace via sysfs. So remove the flag, allowing drivers to see the data directly (a followon patch validates the passed driver_data value against what the drivers expect). Acked-by: Greg Kroah-Hartman <gregkh@suse.de> Acked-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Milton Miller <miltonm@bga.com> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Diffstat (limited to 'drivers/scsi')
-rw-r--r--drivers/scsi/ipr.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index d30eb7b..098739d 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -7859,7 +7859,6 @@ static struct pci_driver ipr_driver = {
.remove = ipr_remove,
.shutdown = ipr_shutdown,
.err_handler = &ipr_err_handler,
- .dynids.use_driver_data = 1
};
/**
OpenPOWER on IntegriCloud