diff options
| author | Tomas Henzl <thenzl@redhat.com> | 2014-07-30 16:40:51 +0200 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2014-08-01 08:16:40 -0400 |
| commit | 5bd355ee3b0191c6846918b049b3940182bec1cb (patch) | |
| tree | 2665003f95df9bd30bec4dcfd71ed11f7444749e /drivers/scsi | |
| parent | f5a7b5252f8a1755d065f07d9fc7752a6605743b (diff) | |
| download | op-kernel-dev-5bd355ee3b0191c6846918b049b3940182bec1cb.zip op-kernel-dev-5bd355ee3b0191c6846918b049b3940182bec1cb.tar.gz | |
pm8001: Fix erratic calculation in update_flash
The loopcount is calculated by using some weird magic. Use instead a boring
macro.
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
Acked-by: Suresh Thiagarajan <Suresh.Thiagarajan@pmcs.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/scsi')
| -rw-r--r-- | drivers/scsi/pm8001/pm8001_ctl.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c index d3a08ae..e9b0921 100644 --- a/drivers/scsi/pm8001/pm8001_ctl.c +++ b/drivers/scsi/pm8001/pm8001_ctl.c @@ -581,11 +581,8 @@ static int pm8001_update_flash(struct pm8001_hba_info *pm8001_ha) partitionSizeTmp = *(u32 *)((u8 *)&image_hdr->image_length + sizeRead); partitionSize = be32_to_cpu(partitionSizeTmp); - loopcount = (partitionSize + HEADER_LEN)/IOCTL_BUF_SIZE; - if (loopcount % IOCTL_BUF_SIZE) - loopcount++; - if (loopcount == 0) - loopcount++; + loopcount = DIV_ROUND_UP(partitionSize + HEADER_LEN, + IOCTL_BUF_SIZE); for (loopNumber = 0; loopNumber < loopcount; loopNumber++) { payload = (struct pm8001_ioctl_payload *)ioctlbuffer; payload->length = 1024*16; |
