diff options
| author | Matthew Wilcox <matthew@wil.cx> | 2007-10-05 15:57:06 -0400 |
|---|---|---|
| committer | James Bottomley <James.Bottomley@HansenPartnership.com> | 2008-03-07 10:05:43 -0600 |
| commit | 951b62c11e86acf8c55d9828aa8c921575023c29 (patch) | |
| tree | f9caeba567b96d05d22af36a4076bcf81133c897 /drivers/scsi | |
| parent | ce4796d1e16cf3761dc2a02b8d588667d05b3078 (diff) | |
| download | op-kernel-dev-951b62c11e86acf8c55d9828aa8c921575023c29.zip op-kernel-dev-951b62c11e86acf8c55d9828aa8c921575023c29.tar.gz | |
[SCSI] advansys: Fix bug in AdvLoadMicrocode
buf[i] can be up to 0xfd, so doubling it and assigning the result to an
unsigned char truncates the value. Just use an unsigned int instead;
it's only a temporary.
Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
Cc: Stable Tree <stable@kernel.org>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Diffstat (limited to 'drivers/scsi')
| -rw-r--r-- | drivers/scsi/advansys.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c index 3c2d688..8591585 100644 --- a/drivers/scsi/advansys.c +++ b/drivers/scsi/advansys.c @@ -6439,7 +6439,7 @@ static int AdvLoadMicrocode(AdvPortAddr iop_base, unsigned char *buf, int size, i += 2; len += 2; } else { - unsigned char off = buf[i] * 2; + unsigned int off = buf[i] * 2; unsigned short word = (buf[off + 1] << 8) | buf[off]; AdvWriteWordAutoIncLram(iop_base, word); len += 2; |
