summaryrefslogtreecommitdiffstats
path: root/drivers/scsi
diff options
context:
space:
mode:
authorInsu Yun <wuninsu@gmail.com>2016-01-06 12:44:01 -0500
committerMartin K. Petersen <martin.petersen@oracle.com>2016-01-07 21:51:19 -0500
commitd63c7dd5bcb9441af0526d370c43a65ca2c980d9 (patch)
tree63e4b30f998ecafe86821e5e4590973f1acebd97 /drivers/scsi
parent9055082fb100cc66e20c048251d05159f5f2cfba (diff)
downloadop-kernel-dev-d63c7dd5bcb9441af0526d370c43a65ca2c980d9.zip
op-kernel-dev-d63c7dd5bcb9441af0526d370c43a65ca2c980d9.tar.gz
ipr: Fix out-of-bounds null overwrite
Return value of snprintf is not bound by size value, 2nd argument. (https://www.kernel.org/doc/htmldocs/kernel-api/API-snprintf.html). Return value is number of printed chars, can be larger than 2nd argument. Therefore, it can write null byte out of bounds ofbuffer. Since snprintf puts null, it does not need to put additional null byte. Signed-off-by: Insu Yun <wuninsu@gmail.com> Reviewed-by: Shane Seymour <shane.seymour@hpe.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi')
-rw-r--r--drivers/scsi/ipr.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index 536cd5a..1c3759b 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -4003,13 +4003,12 @@ static ssize_t ipr_store_update_fw(struct device *dev,
struct ipr_sglist *sglist;
char fname[100];
char *src;
- int len, result, dnld_size;
+ int result, dnld_size;
if (!capable(CAP_SYS_ADMIN))
return -EACCES;
- len = snprintf(fname, 99, "%s", buf);
- fname[len-1] = '\0';
+ snprintf(fname, sizeof(fname), "%s", buf);
if (request_firmware(&fw_entry, fname, &ioa_cfg->pdev->dev)) {
dev_err(&ioa_cfg->pdev->dev, "Firmware file %s not found\n", fname);
OpenPOWER on IntegriCloud