diff options
| author | Hannes Reinecke <hare@suse.de> | 2017-08-15 10:21:41 +0200 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2017-08-24 22:28:58 -0400 |
| commit | acf8ab9a85bfd6ead185a59c4cfe26b25d5a082f (patch) | |
| tree | bc20b7ff2f08e4d35b54c1c4d8203dc4d63e1630 /drivers/scsi | |
| parent | c8cd71f1f32a6227ecadbbbaaf3147a41292ecb5 (diff) | |
| download | op-kernel-dev-acf8ab9a85bfd6ead185a59c4cfe26b25d5a082f.zip op-kernel-dev-acf8ab9a85bfd6ead185a59c4cfe26b25d5a082f.tar.gz | |
scsi: ses: check return code from ses_recv_diag()
We should be checking the return code from ses_recv_diag() to avoid
accessing invalid data.
Signed-off-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi')
| -rw-r--r-- | drivers/scsi/ses.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/scsi/ses.c b/drivers/scsi/ses.c index f1cdf32..2a651b2 100644 --- a/drivers/scsi/ses.c +++ b/drivers/scsi/ses.c @@ -179,7 +179,8 @@ static unsigned char *ses_get_page2_descriptor(struct enclosure_device *edev, unsigned char *type_ptr = ses_dev->page1_types; unsigned char *desc_ptr = ses_dev->page2 + 8; - ses_recv_diag(sdev, 2, ses_dev->page2, ses_dev->page2_len); + if (ses_recv_diag(sdev, 2, ses_dev->page2, ses_dev->page2_len) < 0) + return NULL; for (i = 0; i < ses_dev->page1_num_types; i++, type_ptr += 4) { for (j = 0; j < type_ptr[1]; j++) { |
