summaryrefslogtreecommitdiffstats
path: root/drivers/scsi
diff options
context:
space:
mode:
authorJames Bottomley <James.Bottomley@steeleye.com>2006-12-11 09:47:06 -0600
committerJames Bottomley <jejb@mulgrave.il.steeleye.com>2007-01-03 16:57:35 -0600
commit4ed381ee559ebfab32d3b21896c204992c36179a (patch)
treeac0f8be42418ecb7a7b4b5d02b5bfa6e274e84fc /drivers/scsi
parent8bcc24127be12967588db0ad0e614be937ee1d5a (diff)
downloadop-kernel-dev-4ed381ee559ebfab32d3b21896c204992c36179a.zip
op-kernel-dev-4ed381ee559ebfab32d3b21896c204992c36179a.tar.gz
[SCSI] scsi_transport_spi: fix sense buffer size error
The code does this: unsigned char sense[SCSI_SENSE_BUFFERSIZE]; ... scsi_normalize_sense(sense, sizeof(*sense), sshdr) however the sizeof will return 1 not 96 which means the sense data will have no valid ASC/ASCQ values. Fix by putting the correct sense size. The only affected case for this would have been the DV buffer sanity check failure, which is fortunately quite rare. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi')
-rw-r--r--drivers/scsi/scsi_transport_spi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/scsi_transport_spi.c b/drivers/scsi/scsi_transport_spi.c
index 3fded48..014d7fe 100644
--- a/drivers/scsi/scsi_transport_spi.c
+++ b/drivers/scsi/scsi_transport_spi.c
@@ -122,7 +122,7 @@ static int spi_execute(struct scsi_device *sdev, const void *cmd,
if (!sshdr)
sshdr = &sshdr_tmp;
- if (scsi_normalize_sense(sense, sizeof(*sense),
+ if (scsi_normalize_sense(sense, SCSI_SENSE_BUFFERSIZE,
sshdr)
&& sshdr->sense_key == UNIT_ATTENTION)
continue;
OpenPOWER on IntegriCloud