diff options
author | Johannes Thumshirn <jthumshirn@suse.de> | 2017-01-31 10:16:00 +0100 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2017-02-19 09:49:15 -0800 |
commit | fd3fc0b4d7305fa7246622dcc0dec69c42443f45 (patch) | |
tree | f66560ae05fd7b68c20b687d4f08981eb810ab80 /drivers/scsi/sg.c | |
parent | 00ea1ceebe0d9f2dc1cc2b7bd575a00100c27869 (diff) | |
download | op-kernel-dev-fd3fc0b4d7305fa7246622dcc0dec69c42443f45.zip op-kernel-dev-fd3fc0b4d7305fa7246622dcc0dec69c42443f45.tar.gz |
scsi: don't BUG_ON() empty DMA transfers
Don't crash the machine just because of an empty transfer. Use WARN_ON()
combined with returning an error.
Found by Dmitry Vyukov and syzkaller.
[ Changed to "WARN_ON_ONCE()". Al has a patch that should fix the root
cause, but a BUG_ON() is not acceptable in any case, and a WARN_ON()
might still be a cause of excessive log spamming.
NOTE! If this warning ever triggers, we may end up leaking resources,
since this doesn't bother to try to clean the command up. So this
WARN_ON_ONCE() triggering does imply real problems. But BUG_ON() is
much worse.
People really need to stop using BUG_ON() for "this shouldn't ever
happen". It makes pretty much any bug worse. - Linus ]
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Cc: James Bottomley <jejb@linux.vnet.ibm.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/scsi/sg.c')
0 files changed, 0 insertions, 0 deletions