diff options
| author | Martin K. Petersen <martin.petersen@oracle.com> | 2013-10-23 06:25:40 -0400 |
|---|---|---|
| committer | James Bottomley <JBottomley@Parallels.com> | 2013-11-29 08:48:39 +0400 |
| commit | 54b2b50c20a61b51199bedb6e5d2f8ec2568fb43 (patch) | |
| tree | 8bff3a0f9bc3a5577cb4191ee8043aa98d081b87 /drivers/scsi/sd.c | |
| parent | ae5fbae0ccd982dfca0ce363036ed92f5b13f150 (diff) | |
| download | op-kernel-dev-54b2b50c20a61b51199bedb6e5d2f8ec2568fb43.zip op-kernel-dev-54b2b50c20a61b51199bedb6e5d2f8ec2568fb43.tar.gz | |
[SCSI] Disable WRITE SAME for RAID and virtual host adapter drivers
Some host adapters do not pass commands through to the target disk
directly. Instead they provide an emulated target which may or may not
accurately report its capabilities. In some cases the physical device
characteristics are reported even when the host adapter is processing
commands on the device's behalf. This can lead to adapter firmware hangs
or excessive I/O errors.
This patch disables WRITE SAME for devices connected to host adapters
that provide an emulated target. Driver writers can disable WRITE SAME
by setting the no_write_same flag in the host adapter template.
[jejb: fix up rejections due to eh_deadline patch]
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Cc: stable@kernel.org
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/sd.c')
| -rw-r--r-- | drivers/scsi/sd.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index e6c4bff..69725f7 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -2659,6 +2659,12 @@ static void sd_read_write_same(struct scsi_disk *sdkp, unsigned char *buffer) { struct scsi_device *sdev = sdkp->device; + if (sdev->host->no_write_same) { + sdev->no_write_same = 1; + + return; + } + if (scsi_report_opcode(sdev, buffer, SD_BUF_SIZE, INQUIRY) < 0) { /* too large values might cause issues with arcmsr */ int vpd_buf_len = 64; |
