summaryrefslogtreecommitdiffstats
path: root/drivers/scsi/sd.c
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2017-08-30 16:30:35 +0300
committerMartin K. Petersen <martin.petersen@oracle.com>2017-08-30 22:06:20 -0400
commite6f77540c067b48dee10f1e33678415bfcc89017 (patch)
tree61834b8b55fec5959bd84c127eb9814b39afe340 /drivers/scsi/sd.c
parent0208eeaa650c5c866a3242201678a19e6dc4a14e (diff)
downloadop-kernel-dev-e6f77540c067b48dee10f1e33678415bfcc89017.zip
op-kernel-dev-e6f77540c067b48dee10f1e33678415bfcc89017.tar.gz
scsi: qla2xxx: Fix an integer overflow in sysfs code
The value of "size" comes from the user. When we add "start + size" it could lead to an integer overflow bug. It means we vmalloc() a lot more memory than we had intended. I believe that on 64 bit systems vmalloc() can succeed even if we ask it to allocate huge 4GB buffers. So we would get memory corruption and likely a crash when we call ha->isp_ops->write_optrom() and ->read_optrom(). Only root can trigger this bug. Link: https://bugzilla.kernel.org/show_bug.cgi?id=194061 Cc: <stable@vger.kernel.org> Fixes: b7cc176c9eb3 ("[SCSI] qla2xxx: Allow region-based flash-part accesses.") Reported-by: shqking <shqking@gmail.com> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/sd.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud