diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2017-05-04 00:23:57 +0300 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2017-05-08 21:51:39 -0400 |
| commit | 0d2fc3b48ba0e267962c861c5258564c335dd1f2 (patch) | |
| tree | 439b99f0e57b457407c771e6329076572d15a5c6 /drivers/scsi/qedf | |
| parent | 0d618cf4f24cebb822eaf57c27985266e4110176 (diff) | |
| download | op-kernel-dev-0d2fc3b48ba0e267962c861c5258564c335dd1f2.zip op-kernel-dev-0d2fc3b48ba0e267962c861c5258564c335dd1f2.tar.gz | |
scsi: qedf: Cleanup the type of io_log->op
We store sc_cmd->cmnd[0] which is an unsigned char in io_log->op so
this should also be unsigned char. The other thing is that this is
displayed in the debugfs:
seq_printf(s, "0x%02x:", io_log->op);
Smatch complains that the formatting won't work for negative values so
changing it to unsigned silences that warning as well.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Chad Dupuis <chad.dupuis@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/qedf')
| -rw-r--r-- | drivers/scsi/qedf/qedf.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/qedf/qedf.h b/drivers/scsi/qedf/qedf.h index 40aeb6b..07ee882 100644 --- a/drivers/scsi/qedf/qedf.h +++ b/drivers/scsi/qedf/qedf.h @@ -259,7 +259,7 @@ struct qedf_io_log { uint16_t task_id; uint32_t port_id; /* Remote port fabric ID */ int lun; - char op; /* SCSI CDB */ + unsigned char op; /* SCSI CDB */ uint8_t lba[4]; unsigned int bufflen; /* SCSI buffer length */ unsigned int sg_count; /* Number of SG elements */ |
