diff options
| author | Santosh Nayak <santoshprasadnayak@gmail.com> | 2012-02-26 19:03:30 +0530 |
|---|---|---|
| committer | James Bottomley <JBottomley@Parallels.com> | 2012-02-29 16:49:55 -0600 |
| commit | bdaefbf580cd200ae3230b6aacd1f4f2dadb18e3 (patch) | |
| tree | d916cbf8b7cd029699875d0776193d81a7883d03 /drivers/scsi/pcmcia/nsp_cs.c | |
| parent | cd9b3d04b4cae6bdfd639e603649777f819ed783 (diff) | |
| download | op-kernel-dev-bdaefbf580cd200ae3230b6aacd1f4f2dadb18e3.zip op-kernel-dev-bdaefbf580cd200ae3230b6aacd1f4f2dadb18e3.tar.gz | |
[SCSI] pm8001: Fix bogus interrupt state flag issue.
Static checker is giving following warning:
" error: calling 'spin_unlock_irqrestore()' with bogus flags"
The code flow is as shown below:
process_oq() --> process_one_iomb --> mpi_sata_completion
In 'mpi_sata_completion'
the first call for 'spin_unlock_irqrestore()' is with flags=0,
which is as good as 'spin_unlock_irq()' ( unconditional interrupt
enabling).
So for better performance 'spin_unlock_irqrestore()' can be replaced
with 'spin_unlock_irq()' and 'spin_lock_irqsave()' can be replaced by
'spin_lock_irq()'.
Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
Acked-by: Jack Wang <jack_wang@usish.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/pcmcia/nsp_cs.c')
0 files changed, 0 insertions, 0 deletions
