summaryrefslogtreecommitdiffstats
path: root/drivers/scsi/osd/osd_initiator.c
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2017-06-03 09:37:55 +0200
committerJens Axboe <axboe@fb.com>2017-06-09 09:27:32 -0600
commit10f64ec5dded10f680f891e92fb4c65f4b7147a2 (patch)
tree45680a7057fed2b6666f04f7bafa70b58a71130e /drivers/scsi/osd/osd_initiator.c
parent401741547f95c0883fe143ac446d92c772937556 (diff)
downloadop-kernel-dev-10f64ec5dded10f680f891e92fb4c65f4b7147a2.zip
op-kernel-dev-10f64ec5dded10f680f891e92fb4c65f4b7147a2.tar.gz
scsi/osd: don't save block errors into req_results
We will only have sense data if the command executed and got a SCSI result, so this is pointless. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'drivers/scsi/osd/osd_initiator.c')
-rw-r--r--drivers/scsi/osd/osd_initiator.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c
index 8a1b948..1478517 100644
--- a/drivers/scsi/osd/osd_initiator.c
+++ b/drivers/scsi/osd/osd_initiator.c
@@ -477,7 +477,7 @@ static void _set_error_resid(struct osd_request *or, struct request *req,
int error)
{
or->async_error = error;
- or->req_errors = scsi_req(req)->result ? : error;
+ or->req_errors = scsi_req(req)->result;
or->sense_len = scsi_req(req)->sense_len;
if (or->sense_len)
memcpy(or->sense, scsi_req(req)->sense, or->sense_len);
OpenPOWER on IntegriCloud