diff options
| author | Andreea-Cristina Bernat <bernat.ada@gmail.com> | 2014-08-18 17:56:22 +0300 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2014-09-30 09:28:36 +0200 |
| commit | f4303d8fa6da702b5fe53fa91a6984941d89d514 (patch) | |
| tree | 0246ccff9c4d85caec144dcae9773c271ff584a4 /drivers/scsi/libfc | |
| parent | b8d23dc6133c495cf9161dfb36988bbbe163461d (diff) | |
| download | op-kernel-dev-f4303d8fa6da702b5fe53fa91a6984941d89d514.zip op-kernel-dev-f4303d8fa6da702b5fe53fa91a6984941d89d514.tar.gz | |
libfc: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
The uses of "rcu_assign_pointer()" are NULLing out the pointers.
According to RCU_INIT_POINTER()'s block comment:
"1. This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a
smaller overhead.
The following Coccinelle semantic patch was used:
@@
@@
- rcu_assign_pointer
+ RCU_INIT_POINTER
(..., NULL)
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Acked-by: Vasu Dev <vasu.dev@intel.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/scsi/libfc')
| -rw-r--r-- | drivers/scsi/libfc/fc_libfc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/scsi/libfc/fc_libfc.c b/drivers/scsi/libfc/fc_libfc.c index 8d65a51a..c11a638 100644 --- a/drivers/scsi/libfc/fc_libfc.c +++ b/drivers/scsi/libfc/fc_libfc.c @@ -296,9 +296,9 @@ void fc_fc4_deregister_provider(enum fc_fh_type type, struct fc4_prov *prov) BUG_ON(type >= FC_FC4_PROV_SIZE); mutex_lock(&fc_prov_mutex); if (prov->recv) - rcu_assign_pointer(fc_passive_prov[type], NULL); + RCU_INIT_POINTER(fc_passive_prov[type], NULL); else - rcu_assign_pointer(fc_active_prov[type], NULL); + RCU_INIT_POINTER(fc_active_prov[type], NULL); mutex_unlock(&fc_prov_mutex); synchronize_rcu(); } |
