summaryrefslogtreecommitdiffstats
path: root/drivers/scsi/isci
diff options
context:
space:
mode:
authorJeff Skirvin <jeffrey.d.skirvin@intel.com>2012-03-12 17:29:51 -0700
committerDan Williams <dan.j.williams@intel.com>2012-05-17 14:33:44 -0700
commit3ef768c6c0caa83b9fe66f19a18898ed0315ac36 (patch)
treecf8233efe91dfac3232f06a51f58c4e4c5a508b3 /drivers/scsi/isci
parentf8381807ebdfffa34c2c5aa38eda33673d1a7adf (diff)
downloadop-kernel-dev-3ef768c6c0caa83b9fe66f19a18898ed0315ac36.zip
op-kernel-dev-3ef768c6c0caa83b9fe66f19a18898ed0315ac36.tar.gz
isci: Manage the IREQ_NO_AUTO_FREE_TAG under scic_lock.
Since there is a possibilty of a timeout waiting for the RNC suspension, handle the exit case from the task termination under scic_lock, and leave the tag allocated if the termination timed-out. Signed-off-by: Jeff Skirvin <jeffrey.d.skirvin@intel.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/scsi/isci')
-rw-r--r--drivers/scsi/isci/remote_device.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/scsi/isci/remote_device.c b/drivers/scsi/isci/remote_device.c
index 48765aa..a3a6487 100644
--- a/drivers/scsi/isci/remote_device.c
+++ b/drivers/scsi/isci/remote_device.c
@@ -243,8 +243,11 @@ enum sci_status isci_remote_device_terminate_requests(
idev->rnc.destination_state,
ireq, ireq->flags);
}
+ spin_lock_irqsave(&ihost->scic_lock, flags);
clear_bit(IREQ_NO_AUTO_FREE_TAG, &ireq->flags);
- isci_free_tag(ihost, ireq->io_tag);
+ if (!test_bit(IREQ_ABORT_PATH_ACTIVE, &ireq->flags))
+ isci_free_tag(ihost, ireq->io_tag);
+ spin_unlock_irqrestore(&ihost->scic_lock, flags);
} else {
/* Terminate all TCs. */
sci_remote_device_terminate_requests(idev);
OpenPOWER on IntegriCloud