diff options
| author | Alan Cox <alan@lxorguk.ukuu.org.uk> | 2006-08-10 16:59:10 +0900 |
|---|---|---|
| committer | Tejun Heo <htejun@gmail.com> | 2006-08-10 16:59:10 +0900 |
| commit | 2ec7df0457b710d9201f211dbccdbecf0ad38b7e (patch) | |
| tree | 4fbffc3e05aa65fd9ed63b4ac809712719e19cda /drivers/scsi/ata_piix.c | |
| parent | 37deecb5139ee431233781a9a093d9fcaab54c5b (diff) | |
| download | op-kernel-dev-2ec7df0457b710d9201f211dbccdbecf0ad38b7e.zip op-kernel-dev-2ec7df0457b710d9201f211dbccdbecf0ad38b7e.tar.gz | |
[PATCH] libata: rework legacy handling to remove much of the cruft
Kill host_set->next
Fix simplex support
Allow per platform setting of IDE legacy bases
Some of this can be tidied further later on, in particular all the
legacy port gunge belongs as a PCI quirk/PCI header decode to understand
the special legacy IDE rules in the PCI spec.
Longer term Jeff also wants to move the request_irq/free_irq out of core
which will make this even cleaner.
tj: folded in three followup patches - ata_piix-fix, broken-arch-fix
and fix-new-legacy-handling, and separated per-dev xfermask into
separate patch preceding this one. Folded in fixes are...
* ata_piix-fix: fix build failure due to host_set->next removal
* broken-arch-fix: add missing include/asm-*/libata-portmap.h
* fix-new-legacy-handling:
* In ata_pci_init_legacy_port(), probe_num was incorrectly
incremented during initialization of the secondary port and
probe_ent->n_ports was incorrectly fixed to 1.
* Both legacy ports ended up having the same hard_port_no.
* When printing port information, both legacy ports printed
the first irq.
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Tejun Heo <htejun@gmail.com>
Diffstat (limited to 'drivers/scsi/ata_piix.c')
| -rw-r--r-- | drivers/scsi/ata_piix.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/scsi/ata_piix.c b/drivers/scsi/ata_piix.c index 5e8afc8..40ecab5 100644 --- a/drivers/scsi/ata_piix.c +++ b/drivers/scsi/ata_piix.c @@ -932,8 +932,6 @@ static int piix_init_one (struct pci_dev *pdev, const struct pci_device_id *ent) static void piix_host_stop(struct ata_host_set *host_set) { - if (host_set->next == NULL) - kfree(host_set->private_data); ata_host_stop(host_set); } |
