diff options
author | Al Viro <viro@ftp.linux.org.uk> | 2008-11-22 17:34:54 +0000 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-11-30 10:03:36 -0800 |
commit | 30037818f7c1e11cb3742fbecd614ef3dc7b27bb (patch) | |
tree | de09371c449e130eac12bc195efedea420488683 /drivers/sbus | |
parent | 2fceab0bd8d82509519e9b842a5a7234b2397fb4 (diff) | |
download | op-kernel-dev-30037818f7c1e11cb3742fbecd614ef3dc7b27bb.zip op-kernel-dev-30037818f7c1e11cb3742fbecd614ef3dc7b27bb.tar.gz |
advansys fix on ISA-less configs
The code
if (shost->dma_channel != NO_ISA_DMA)
free_dma(shost->dma_channel);
in there is triggerable only if we have CONFIG_ISA (we only set ->dma_channel to
something other than NO_ISA_DMA under #ifdef CONFIG_ISA). OTOH, free_dma() is
not guaranteed to be there in absense of CONFIG_ISA. IOW, driver runs into
undefined symbols on PCI-but-not-ISA configs (e.g. on frv) and it's a false
positive.
Fix: put the entire if () under #ifdef CONFIG_ISA; behaviour doesn't change and
dependency on free_dma() disappears for !CONFIG_ISA.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/sbus')
0 files changed, 0 insertions, 0 deletions