diff options
| author | Jiri Slaby <jslaby@suse.cz> | 2012-03-05 14:52:01 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-03-08 11:42:21 -0800 |
| commit | 410235fd4d20b8feaf8930a0575d23acc088aa87 (patch) | |
| tree | ad21d071a29ef0ad400393328ca4ab0588d5b2b7 /drivers/s390 | |
| parent | 44a1bfd95d0a6c0096e79a883197596e1ce83cc3 (diff) | |
| download | op-kernel-dev-410235fd4d20b8feaf8930a0575d23acc088aa87.zip op-kernel-dev-410235fd4d20b8feaf8930a0575d23acc088aa87.tar.gz | |
TTY: remove unneeded tty->index checks
Checking if tty->index is in bounds is not needed. The tty has the
index set in the initial open. This is done in get_tty_driver. And it
can be only in interval <0,driver->num).
So remove the tests which check exactly this interval. Some are
left untouched as they check against the current backing device count.
(Leaving apart that the check is racy in most of the cases.)
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/s390')
| -rw-r--r-- | drivers/s390/char/con3215.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c index fe916bf..ed23fec 100644 --- a/drivers/s390/char/con3215.c +++ b/drivers/s390/char/con3215.c @@ -926,13 +926,9 @@ console_initcall(con3215_init); static int tty3215_open(struct tty_struct *tty, struct file * filp) { struct raw3215_info *raw; - int retval, line; + int retval; - line = tty->index; - if ((line < 0) || (line >= NR_3215)) - return -ENODEV; - - raw = raw3215[line]; + raw = raw3215[tty->index]; if (raw == NULL) return -ENODEV; |
