diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2013-09-11 06:49:20 +0800 |
|---|---|---|
| committer | Martin Schwidefsky <schwidefsky@de.ibm.com> | 2013-09-30 13:04:38 +0200 |
| commit | 8f0ba630af45235a6866054704531d49e524e49a (patch) | |
| tree | f16ad79e8df676bd837dc36d5d05f2dc789e8112 /drivers/s390 | |
| parent | 15c03dd4859ab16f9212238f29dd315654aa94f6 (diff) | |
| download | op-kernel-dev-8f0ba630af45235a6866054704531d49e524e49a.zip op-kernel-dev-8f0ba630af45235a6866054704531d49e524e49a.tar.gz | |
s390/3270: fix return value check in tty3270_resize_work()
In case of error, the function tty3270_alloc_screen() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'drivers/s390')
| -rw-r--r-- | drivers/s390/char/tty3270.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/s390/char/tty3270.c b/drivers/s390/char/tty3270.c index a0f47c8..3f4ca4e 100644 --- a/drivers/s390/char/tty3270.c +++ b/drivers/s390/char/tty3270.c @@ -810,7 +810,7 @@ static void tty3270_resize_work(struct work_struct *work) struct winsize ws; screen = tty3270_alloc_screen(tp->n_rows, tp->n_cols); - if (!screen) + if (IS_ERR(screen)) return; /* Switch to new output size */ spin_lock_bh(&tp->view.lock); |
