diff options
| author | Stefan Weil <weil@mail.berlios.de> | 2011-02-02 06:04:36 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-02-02 15:00:02 -0800 |
| commit | 08b018327c2e8412fd76f821e9bb9de36ef48cb1 (patch) | |
| tree | 82a35122e29b5ba6ee4b0876e8eaaf889760c6b3 /drivers/s390/net | |
| parent | 5df979d6922d50cc12bfbe83721c143a5d0d31b7 (diff) | |
| download | op-kernel-dev-08b018327c2e8412fd76f821e9bb9de36ef48cb1.zip op-kernel-dev-08b018327c2e8412fd76f821e9bb9de36ef48cb1.tar.gz | |
s390: Fix possibly wrong size in strncmp (smsgiucv)
This error was reported by cppcheck:
drivers/s390/net/smsgiucv.c:63: error: Using sizeof for array given as
function argument returns the size of pointer.
Although there is no runtime problem as long as sizeof(u8 *) == 8,
this misleading code should get fixed.
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/s390/net')
| -rw-r--r-- | drivers/s390/net/smsgiucv.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/s390/net/smsgiucv.c b/drivers/s390/net/smsgiucv.c index 65e1cf1..207b7d7 100644 --- a/drivers/s390/net/smsgiucv.c +++ b/drivers/s390/net/smsgiucv.c @@ -60,7 +60,7 @@ static struct iucv_handler smsg_handler = { static int smsg_path_pending(struct iucv_path *path, u8 ipvmid[8], u8 ipuser[16]) { - if (strncmp(ipvmid, "*MSG ", sizeof(ipvmid)) != 0) + if (strncmp(ipvmid, "*MSG ", 8) != 0) return -EINVAL; /* Path pending from *MSG. */ return iucv_path_accept(path, &smsg_handler, "SMSGIUCV ", NULL); |
