summaryrefslogtreecommitdiffstats
path: root/drivers/regulator
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@ingics.com>2013-01-27 20:54:40 +0800
committerMark Brown <broonie@opensource.wolfsonmicro.com>2013-01-30 18:44:41 +0800
commit0ce7d00d0d7bc04d917b8775da177dde962ce17e (patch)
tree14add8968867ea2574a55f0e8bdec8b12e38e7f2 /drivers/regulator
parent6116ad94e1205b33a4c96530474844cd2a1ac21d (diff)
downloadop-kernel-dev-0ce7d00d0d7bc04d917b8775da177dde962ce17e.zip
op-kernel-dev-0ce7d00d0d7bc04d917b8775da177dde962ce17e.tar.gz
regulator: tps6507x: Fix using wrong dev argument for calling of_regulator_match
The dev parameter is the device requesting the data. In this case it should be &pdev->dev rather than pdev->dev.parent. The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(), which means this fixes a memory leak because the memory is allocated every time probe() is called, thus it should be freed when this driver is unloaded. Signed-off-by: Axel Lin <axel.lin@ingics.com> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'drivers/regulator')
-rw-r--r--drivers/regulator/tps6507x-regulator.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/regulator/tps6507x-regulator.c b/drivers/regulator/tps6507x-regulator.c
index afdeb65..54aa2da 100644
--- a/drivers/regulator/tps6507x-regulator.c
+++ b/drivers/regulator/tps6507x-regulator.c
@@ -394,7 +394,7 @@ static struct tps6507x_board *tps6507x_parse_dt_reg_data(
count = ARRAY_SIZE(tps6507x_matches);
matches = tps6507x_matches;
- ret = of_regulator_match(pdev->dev.parent, regulators, matches, count);
+ ret = of_regulator_match(&pdev->dev, regulators, matches, count);
if (ret < 0) {
dev_err(&pdev->dev, "Error parsing regulator init data: %d\n",
ret);
OpenPOWER on IntegriCloud