summaryrefslogtreecommitdiffstats
path: root/drivers/pwm
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@ingics.com>2013-06-20 01:27:27 +0800
committerThierry Reding <thierry.reding@gmail.com>2013-06-26 23:23:54 +0200
commitfed1bf8dc76cd102892379fce59b9ba237afd438 (patch)
treeb035f2e9f6b6d9f4039088f0578d9717eb252384 /drivers/pwm
parent71077bc8db67f560453d62c48e3bec467ec6b37f (diff)
downloadop-kernel-dev-fed1bf8dc76cd102892379fce59b9ba237afd438.zip
op-kernel-dev-fed1bf8dc76cd102892379fce59b9ba237afd438.tar.gz
pwm: pca9685: Fix wrong argument to set MODE1_SLEEP bit
Current code actually does not set MODE1_SLEEP bit because the new value for bitmask (0x1) is wrong. To set MODE1_SLEEP bit, we should pass MODE1_SLEEP as the new value for bitmask. Signed-off-by: Axel Lin <axel.lin@ingics.com> Reviewed-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Diffstat (limited to 'drivers/pwm')
-rw-r--r--drivers/pwm/pwm-pca9685.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c
index c9f9e65..3fb775d 100644
--- a/drivers/pwm/pwm-pca9685.c
+++ b/drivers/pwm/pwm-pca9685.c
@@ -190,7 +190,7 @@ static void pca9685_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm)
if (--pca->active_cnt == 0)
regmap_update_bits(pca->regmap, PCA9685_MODE1, MODE1_SLEEP,
- 0x1);
+ MODE1_SLEEP);
}
static const struct pwm_ops pca9685_pwm_ops = {
@@ -264,7 +264,8 @@ static int pca9685_pwm_remove(struct i2c_client *client)
{
struct pca9685 *pca = i2c_get_clientdata(client);
- regmap_update_bits(pca->regmap, PCA9685_MODE1, MODE1_SLEEP, 0x1);
+ regmap_update_bits(pca->regmap, PCA9685_MODE1, MODE1_SLEEP,
+ MODE1_SLEEP);
return pwmchip_remove(&pca->chip);
}
OpenPOWER on IntegriCloud