diff options
| author | Andrzej Hajda <a.hajda@samsung.com> | 2015-09-28 10:51:27 +0200 |
|---|---|---|
| committer | Sebastian Reichel <sre@kernel.org> | 2015-09-28 18:07:48 +0200 |
| commit | 2edd69a81dd4e8068bb512ffcc3959c77fc182ea (patch) | |
| tree | bcccf783ac3d11be9cf03bc7a2c373767aa618de /drivers/power | |
| parent | 2202e1fc5a29eab13fab31d287dd2019dc9edaa6 (diff) | |
| download | op-kernel-dev-2edd69a81dd4e8068bb512ffcc3959c77fc182ea.zip op-kernel-dev-2edd69a81dd4e8068bb512ffcc3959c77fc182ea.tar.gz | |
power: bq27xxx_battery: fix signedness bug in bq27xxx_battery_read_health()
We need flags to be signed for the error handling to work.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
Fixes: 74aab849f342 ('power: bq27xxx_battery: Cleanup health checking')
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-By: Pali Rohár <pali.rohar@gmail.com>
Acked-by: Andrew F. Davis <afd@ti.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
Diffstat (limited to 'drivers/power')
| -rw-r--r-- | drivers/power/bq27xxx_battery.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c index 473aa2f..994c78d 100644 --- a/drivers/power/bq27xxx_battery.c +++ b/drivers/power/bq27xxx_battery.c @@ -691,7 +691,7 @@ static bool bq27xxx_battery_dead(struct bq27xxx_device_info *di, u16 flags) */ static int bq27xxx_battery_read_health(struct bq27xxx_device_info *di) { - u16 flags; + int flags; flags = bq27xxx_read(di, BQ27XXX_REG_FLAGS, false); if (flags < 0) { |
